Add ESLint, checked JS, and CI verification - #60
Merged
MarsLuay merged 1 commit intoSep 20, 2026
Merged
Conversation
Give the extension a deterministic local/CI check that runs tests, correctness-focused linting, and JSDoc type analysis without a transpile or bundle step.
MarsLuay
deleted the
issue-accept/28-5bfb87fa-9f93-42b8-83fe-e4312ab55da7
branch
September 20, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run lint,npm run typecheck, and combinednpm run checkwith ESLint correctness rules, checked JavaScript/JSDoc types, and a lockfile-backed CI workflow.QUEUE_DURABLE_STATE_KEY), runtime messages, queue settings, and the provider adapter contract without converting the extension to TypeScript or adding a bundler.refreshTargetTabs, duplicategetComposerFromEventTargetstub, promise executor returns) and document the commands plus suppression policy inCONTRIBUTING.md.Closes nothing: parent owns merge, verification, and issue #28 closure.
Testing
Commands:
npm test— pass (127 tests)npm run lint— passnpm run typecheck— passnpm run check— passdefinitelyUndefinedIdentifierForLint—npm run lintfailed withno-undefQueueJob.tabId: string—npm run typecheckfailed with TS2322Checklist