Skip to content

Add ESLint, checked JS, and CI verification - #60

Merged
MarsLuay merged 1 commit into
mainfrom
issue-accept/28-5bfb87fa-9f93-42b8-83fe-e4312ab55da7
Sep 20, 2026
Merged

MarsLuay merged 1 commit into
mainfrom
issue-accept/28-5bfb87fa-9f93-42b8-83fe-e4312ab55da7

Conversation

@MarsLuay

Copy link
Copy Markdown
Owner

Summary

  • Add npm run lint, npm run typecheck, and combined npm run check with ESLint correctness rules, checked JavaScript/JSDoc types, and a lockfile-backed CI workflow.
  • Cover queue/job state, durable snapshots (QUEUE_DURABLE_STATE_KEY), runtime messages, queue settings, and the provider adapter contract without converting the extension to TypeScript or adding a bundler.
  • Fix real lint/type issues (duplicate refreshTargetTabs, duplicate getComposerFromEventTarget stub, promise executor returns) and document the commands plus suppression policy in CONTRIBUTING.md.

Closes nothing: parent owns merge, verification, and issue #28 closure.

Testing

  • Ran local tests or lint commands
  • Verified the affected workflow manually

Commands:

  • npm test — pass (127 tests)
  • npm run lint — pass
  • npm run typecheck — pass
  • npm run check — pass
  • Injected definitelyUndefinedIdentifierForLintnpm run lint failed with no-undef
  • Injected QueueJob.tabId: stringnpm run typecheck failed with TS2322

Checklist

  • Updated documentation when behavior changed
  • Followed the code of conduct and contributing guidelines

Give the extension a deterministic local/CI check that runs tests, correctness-focused linting, and JSDoc type analysis without a transpile or bundle step.
Copilot AI lite review requested due to automatic review settings September 20, 2026 18:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MarsLuay
MarsLuay merged commit 09cff81 into main Sep 20, 2026
2 checks passed
@MarsLuay
MarsLuay deleted the issue-accept/28-5bfb87fa-9f93-42b8-83fe-e4312ab55da7 branch September 20, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants