Skip to content

fix(queue): confirm submission and terminal turns before advancing (#43) - #62

Merged
MarsLuay merged 1 commit into
mainfrom
issue-accept/43-5bfb87fa-9f93-42b8-83fe-e4312ab55da7
Sep 20, 2026
Merged

MarsLuay merged 1 commit into
mainfrom
issue-accept/43-5bfb87fa-9f93-42b8-83fe-e4312ab55da7

Conversation

@MarsLuay

Copy link
Copy Markdown
Owner

Summary

  • Require a confirmed matching user turn before a queued command is treated as submitted, so an ignored send click can no longer skip or complete that prompt.
  • Bind response waiting to that command's user/assistant turn and treat idle gaps, delayed generation, errors, interrupts, and waiting-for-user as non-terminal until the bound assistant turn is confirmed.
  • Persist per-command delivery metadata for worker recovery, keep popup idle-wait starts working, and cover the ⚡ Optimize getFallbackMessages by combining querySelectorAll calls #25-docs: expand installation and contribution guides #33 fixture plus restart/skip/duplicate cases.

Test plan

  • npm run check (tests, ESLint, typecheck)
  • Load the unpacked extension, start a multi-command sequence, and confirm command N+1 is not injected while command N is still streaming/researching
  • Ignore or cancel a send and confirm the current command stays in the queue (completedCount does not increase)
  • Restart the service worker mid-send and after confirmed submission; confirm no duplicate send and no dropped prompt
  • Start a popup sequence while ChatGPT is already generating and confirm it still waits for idle first

A send click no longer counts as submission, and idle gaps no longer complete a command. The queue now waits for a matching user turn and a command-bound terminal assistant turn before advancing.
Copilot AI lite review requested due to automatic review settings September 20, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MarsLuay
MarsLuay merged commit e658b95 into main Sep 20, 2026
2 checks passed
@MarsLuay
MarsLuay deleted the issue-accept/43-5bfb87fa-9f93-42b8-83fe-e4312ab55da7 branch September 20, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants