Repository navigation
Fix: Tray window rebuild - #62
Merged
Merged
Conversation
…ruction to use tauri.conf.json configs
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughA versão do projeto foi atualizada para ChangesVersão e reconstrução de janelas
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
Warning Some tools did not complete. Review the errors below. 🔧 Clippy (1.97.1)Clippy execution timed out Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS/Windows/Linux release build failure introduced by the tray grace-period feature:
recreate_splash_windowwas rebuilding the splash window by callingWebviewWindowBuildermethods one by one (.title(),.decorations(),.transparent(), etc.), duplicating whattauri.conf.jsonalready declares..transparent()requires Tauri'sunstablecargo feature, which wasn't enabled - two earlier attempts to fix this by adding atransparentfeature (which doesn't exist) and thenunstableboth worked around the symptom instead of the actual issue.The real fix removes the manual attribute duplication entirely: both
mainandsplashare now rebuilt viaWebviewWindowBuilder::from_config(), reading their definitions straight fromtauri.conf.json- the same construction path Tauri itself uses at boot. This needs no extra cargo feature, and keepstauri.conf.jsonas the single source of truth for window attributes instead of a second copy living in Rust code that can drift out of sync.Related issue
Closes #
Type of change
How was this tested?
npm run tauri buildlocally and confirmed it compiles without anytauricargo feature changes (back to the original["tray-icon", "image-png"]).Checklist
CONTRIBUTING.md.Screenshots or recordings
Add screenshots or recordings for visual changes. Remove sensitive information before posting.
Summary by CodeRabbit
Novidades
Atualizações
v0.2.0-beta.