Repository navigation

API Proposal: Attributes

Jump to bottom

MaulingMonkey edited this page Feb 2, 2020 · 3 revisions

Problems

1. No access to information about generics

Needed for API Proposal: Types

2. Possible codegen changes based on actual attributes

ConstantValue allows defining constants
Deprecated allows marking #[deprecated]
Exceptions could allow eliminating Results if the method can throw no exceptions?
Signature for generics info
RuntimeVisibleAnnotations for annotations
RuntimeInvisibleAnnotations for annotations

3. No access to @Annotations

There's a few of interest:

`androidx.annotation.*`

Codegen Shape

@CheckResult - convert to #[must_use]?
@NonNull - Option generation
@Nullable - Option generation
@Size - use value arrays instead of slices?

Codegen Visibility

@Keep - might warn if missing in some JNI scenarios?
@RequiresApi - docs?
@RequiresFeature - docs?
@RequiresPermission - docs?
@RestrictTo
@VisibleForTesting

Thread Safety

These annotations might be useful for generating or supressing Send/Sync

@AnyThread
@BinderThread
@GuardedBy - the odd one out, akin to clang thread safety annotations...
@MainThread
@UiThread
@WorkerThread

Macro Warnings

@CallSuper - make JNI macros check for super calls?