Skip to content

fix some AP stuff - #2201

Merged
blued-gear merged 15 commits into
mainfrom
fix/get_actor_from_attributed_to
Sep 11, 2026
Merged

fix some AP stuff#2201
blued-gear merged 15 commits into
mainfrom
fix/get_actor_from_attributed_to

Conversation

@blued-gear

@blued-gear blued-gear commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator
  • ActivityPubManager::getActorFromAttributedTo(): array_filter outputs either an array of a Person or a string with an AP URL, but the next line only handled the array version.
  • for some incoming posts which have multiple image attachments, the wrong image is skipped when generating the extra markdown containing the embeddings resulting in the already embedded image replacing it
  • support some more video types
  • fix faulty parsing of inReplyTo attribute (Bridgy Fed images and replies not getting pulled into Mbin #2208)
  • fix bug where mention is not rendered if the mentioned user has a different apId and username

@blued-gear blued-gear changed the title fix ActivityPubManager::getActorFromAttributedTo() fix some AP stuff Aug 8, 2026
Comment thread src/Service/ActivityPubManager.php Outdated
melroy89

This comment was marked as abuse.

@melroy89
melroy89 self-requested a review September 9, 2026 12:42
@blued-gear

Copy link
Copy Markdown
Collaborator Author

The brackets were added and I implemented some test cases for the function.

melroy89
melroy89 previously approved these changes Sep 9, 2026

@melroy89 melroy89 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Comment thread src/Service/ActivityPubManager.php Outdated
@melroy89
melroy89 dismissed their stale review September 10, 2026 20:10

found something new..

@blued-gear
blued-gear merged commit 4cd90fa into main Sep 11, 2026
9 checks passed
@blued-gear
blued-gear deleted the fix/get_actor_from_attributed_to branch September 11, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants