show a summary of the entry / post a comment is from when displaying it in Combined or Microblog - #2206
show a summary of the entry / post a comment is from when displaying it in Combined or Microblog#2206blued-gear wants to merge 12 commits into
Conversation
…it in Combined or Microblog
|
I fixed the merge conflcit in translations/messages.en.yaml for you. just helping you out a bit . |
|
An unrelated but small fix: see commit |
|
Also your test is failing, due to the change withPost true to withPost false with context True.. while the test til lexpects two full parent post elements: $this->assertEquals(2, $crawler->filter('#main .post')->count());Just saying... |
|
pipeline is red again, should I fix it? its just a stupid space |
| if ($content->isVisible() && $author->isVisible()) { | ||
| return true; | ||
| } | ||
| if (($content->isPrivate() || $author->isPrivate()) && $user->isFollowing($author)) { |
There was a problem hiding this comment.
When an anonymous visitor encounters a comment whose parent entry or post has visibility = private, or whose parent author has visibility = private, $user is null, but this line still calls $user->isFollowing($author). Here, private specifically means the private visibility state used for followers-only content or accounts. This causes the whole list page to return a 500 instead of showing the fallback. Please check that $user is not null before checking whether they follow the author.
There was a problem hiding this comment.
Mabye something like this?
if (
null !== $user
&& ($content->isPrivate() || $author->isPrivate())
&& $user->isFollowing($author)
) {
return true;
}
Mobile is a bit "squished"

Comments in the User Overview are now attached to their parents

Closes #2191 and #2190 (somewhat)