Skip to content

show a summary of the entry / post a comment is from when displaying it in Combined or Microblog - #2206

Open
blued-gear wants to merge 12 commits into
mainfrom
fix/context_for_comments
Open

blued-gear wants to merge 12 commits into
mainfrom
fix/context_for_comments

Conversation

@blued-gear

@blued-gear blued-gear commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator
microblog combined boosts

Mobile is a bit "squished"
mobile

Comments in the User Overview are now attached to their parents
overview

Closes #2191 and #2190 (somewhat)

@blued-gear blued-gear added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Aug 10, 2026
@melroy89

melroy89 commented Sep 9, 2026

Copy link
Copy Markdown
Member

I fixed the merge conflcit in translations/messages.en.yaml for you. just helping you out a bit .

Comment thread templates/post/comment/context.html.twig Outdated
@blued-gear

Copy link
Copy Markdown
Collaborator Author

An unrelated but small fix: see commit this is redundant as the same is done in countUpvotes()

@melroy89

Copy link
Copy Markdown
Member

Also your test is failing, due to the change withPost true to withPost false with context True.. while the test til lexpects two full parent post elements:

 $this->assertEquals(2, $crawler->filter('#main .post')->count());

Just saying...

@melroy89

melroy89 commented Sep 12, 2026

Copy link
Copy Markdown
Member

pipeline is red again, should I fix it? its just a stupid space

if ($content->isVisible() && $author->isVisible()) {
return true;
}
if (($content->isPrivate() || $author->isPrivate()) && $user->isFollowing($author)) {

@melroy89 melroy89 Sep 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an anonymous visitor encounters a comment whose parent entry or post has visibility = private, or whose parent author has visibility = private, $user is null, but this line still calls $user->isFollowing($author). Here, private specifically means the private visibility state used for followers-only content or accounts. This causes the whole list page to return a 500 instead of showing the fallback. Please check that $user is not null before checking whether they follow the author.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mabye something like this?

  if (
      null !== $user
      && ($content->isPrivate() || $author->isPrivate())
      && $user->isFollowing($author)
  ) {
      return true;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microblog newest + boosted content includes comments, but they don't show the thread

2 participants