Repository navigation
Hardening threading - #490
Merged
JeromeMartinez merged 7 commits intoOct 12, 2026
Merged
Conversation
The 20260927 and 20261004 snapshots of FFmpeg crash (SIGSEGV) in the ffv1_vulkan encoder with llvmpipe on CPUs without AVX-512 (e.g. AMD EPYC 7763 GitHub runners), so test/vulkan.sh failed depending on the runner. The latest snapshot is still used on CPUs with AVX-512.
A CPU implementation of Vulkan (e.g. lavapipe in the CI) generates code for this CPU, so its model and its AVX-512 support are shown.
The FFmpeg command was taken from cmd_stdout, which is overwritten by the decoding of the swdpx variant, so FFmpeg was not run for the hwdpx variant and the mkv file of the swdpx variant was tested again.
run_ffmpeg() returns the exit code of FFmpeg and keeps the last lines of its error output, without the banner and the progress lines. vulkan.sh shows them, with the signal if FFmpeg crashed, then the Vulkan devices.
The queue was checked without the lock used for enqueuing, so a task enqueued between the check and the wait was not run until another task was enqueued, and a shutdown between the check and the wait was not seen.
Preparation for the output of frames from several threads: the creation of the directory of an output file must not fail if another thread created it between the check and the creation.
Preparation for the output of frames from several threads: the question about an existing output file and the update of the answer are serialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.