Repository navigation
Modernization - #493
Merged
Merged
Modernization#493
Conversation
JeromeMartinez
force-pushed
the
Modernization
branch
from
October 12, 2026 20:38
7412168 to
d28334c
Compare
Remove MSVC2017 and MSVC2019, fix MSVC2022 Coherence of MSVC projects options
The order of file names (e.g. 9 before 10) is computed by a small in-house function instead of alphanum (2008), with the same order except: - numbers are compared without overflow (alphanum overflowed at 10 digits on Windows and returned an int from a long difference elsewhere), - other characters are compared as unsigned bytes (the order of non-ASCII characters was different on x86 and on ARM Linux), - names with numbers differing only by leading zeros are ordered (the order was undefined).
The check never failed: a logical AND was used instead of a bitwise AND (warning with clang), and the byte-swapped format tag was compared with the wrong bytes of fccHandler (read in big endian). The format tag in the fccHandler (e.g. 1 for PCM, also with WAVE_FORMAT_EXTENSIBLE) is now checked against the format tag of the fmt chunk.
Remove a couple of warnings
Update of the bundled zlib from a development version (1.3.1.1) to the 1.3.2 release.
Update of the bundled libFLAC from a development version after 1.3.2 (2018) to the 1.5.0 release. Only the files needed by the stream decoder are kept (metadata, window and bit writer functions are not used). Minimal changes for having it building on MSVC. HAVE_FSEEKO is set by configure, else fseeko and ftello are mapped to fseek and ftell, in conflict with their declarations on macOS.
actions/checkout v3 runs on Node.js 20, which is deprecated on GitHub runners (warning), v7 runs on Node.js 24.
brew update migrates formulae of the runner image (e.g. azure-cli moved to casks) and cleans up, and Homebrew outputs its warnings (e.g. one for each outdated formula of the runner image) as annotations on GitHub Actions. Workflow commands are stopped during the brew commands, so these warnings are only in the log.
JeromeMartinez
force-pushed
the
Modernization
branch
from
October 12, 2026 20:58
d28334c to
cd18ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC projects review.
Natural order of file names: a small C++11 in-house function replaces alphanum
AVI: the check of the format tag in the
fccHandlerof audio streams never failed.configure.ac: current Autoconf and Automake macros, no more warning from Autoconf 2.71 and Automake 1.16.5.
zlib 1.3.2.
libFLAC 1.5.0.