Fix #2288: Bug: internal_info / info stored as JSON string by Neo4j sanitizer but never des

[Memtensor-AI]

Description

Fixes #2288: Neo4jGraphDB / Neo4jCommunityGraphDB sanitize every dict-typed metadata value into a JSON string on write via _sanitize_neo4j_value, but the read path only reversed the sources transform. internal_info and info therefore came back as str, breaking TextualMemoryItem's dict | None pydantic validation during recall on document-ingest / Dream-enabled deployments.

Adds a small _deserialize_dict_field helper in src/memos/graph_dbs/neo4j.py (symmetric with the write-side sanitizer, module constant _DICT_METADATA_FIELDS = ("internal_info", "info")), and wires it into Neo4jGraphDB._parse_node, Neo4jCommunityGraphDB._parse_node, and Neo4jCommunityGraphDB._parse_nodes. JSON-object-shaped strings deserialize to dict; malformed strings fall back to None so pydantic still validates; dict / None / non-object strings pass through unchanged. The write path and other graph backends (Postgres, PolarDB, Nebular) are intentionally untouched — the boundary contract fix mirrors the analogous Postgres work in #2229 / #2270 without expanding scope.

Coverage: 16 new tests in tests/graph_dbs/test_neo4j_internal_info_roundtrip.py — 7 helper unit tests, 8 _parse_node / _parse_nodes regressions for both editions, and one end-to-end guard that feeds the parser output into TreeNodeTextualMemoryMetadata(**metadata) and asserts pydantic validation succeeds, reproducing and closing the exact failure mode from the issue. python3 -m pytest tests/graph_dbs/ tests/memories/textual/ → 107 passed, 3 skipped (Neo4j integration cases behind an opt-in flag). Ruff check + ruff format both clean.

Related Issue (Required): Fixes #2288

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (does not change functionality, e.g. code style improvements, linting)
• Documentation update

How Has This Been Tested?

Not run; documentation-only change.

• Unit Test
• Test Script Or Test Steps (please provide)
• Pipeline Automated API Test (please provide)

Checklist

• I have performed a self-review of my own code
• I have commented my code in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• I have created related documentation issue/PR in MemOS-Docs (if applicable)
• I have linked the issue to this PR (if applicable)
• I have mentioned the person who will review this PR

@wustzdy please review this PR.

Reviewer Checklist

• closes Bug: internal_info / info stored as JSON string by Neo4j sanitizer but never deserialized on read — breaks TextualMemoryItem validation on recall #2288
• Made sure Checks passed
• Tests have been provided

[Memtensor-AI]

🤖 Open Code Review

Target: PR #2289
Task: 9d183872ea1d90db
Base: dev-v2.0.32
Head: bugfix/autodev-2288-20260827081609558
Head SHA: edcdb1d1e146546423e44ae38b262081aa5fc2e1

🔍 OpenCodeReview found 1 issue(s) in this PR.

⚠️ 1 warning(s) occurred during review.

---

1. tests/graph_dbs/test_neo4j_internal_info_roundtrip.py (L39-L43)

Finding #1 is NOT fixed. The _helper() static method still re-imports _deserialize_dict_field on every individual test invocation. A single import at module or class level (e.g., from memos.graph_dbs.neo4j import _deserialize_dict_field at the top of the file or as a class attribute) would be cleaner and more idiomatic.

Suggested fix:

# At module level alongside other imports
from memos.graph_dbs.neo4j import _deserialize_dict_field

class TestDeserializeDictField:
    # Remove _helper() and call _deserialize_dict_field directly in each test
    def test_none_passthrough(self):
        assert _deserialize_dict_field(None) is None

---

🧹 Filtered 1 low-confidence OCR finding(s) before posting/fix-loop (existing_code_mismatch: 1).

Generated by cloud-assistant via Open Code Review.

[Memtensor-AI]

🔧 Open Code Review requested Agent fix

Open Code Review found 2 issue(s). I have resumed the development Agent to fix them.

• Task: 9d183872ea1d90db
• Fix attempt: 1/2
• Finding delta: 0 repeated / 2 new / 0 likely resolved

The Agent will push a new commit to this PR branch. OCR will recheck after the commit is pushed.