Harden sim_gs_n() tests to upstream {gsDesign2} updates - #369
Merged
Conversation
Collaborator
Author
|
I also confirmed locally that the test passes with either the CRAN or GitHub version of {gsDesign2} |
jdblischak
force-pushed
the
robust-test-sim-gs-n
branch
from
August 31, 2026 17:05
9bcd0d6 to
6588ab5
Compare
LittleBeannie
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #368. This PR updates the test of the
sim_gs_n()argumentoriginal_designto be robust to upstream changes in the behavior of {gsDesign2} (in this case, the change in the calculation of the futility bound for the final analysis in Merck/gsDesign2#656). Instead of requiring exact values, it only confirms that 1) the planned bounds match the original design object, and 2) the updated bounds are different from the planned bounds.