Skip to content

fix(dto): cap split-arrays at 50 recipients — bounded release on-chain #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yggdrasilworld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dto): cap split-arrays at 50 recipients — bounded release on-chain #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/escrow/dto/split-release.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ApiProperty } from '@nestjs/swagger';
import { Type } from 'class-transformer';
import {
ArrayMaxSize,
ArrayMinSize,
IsNumber,
IsOptional,
Expand Down Expand Up @@ -29,8 +30,13 @@ export class SplitRecipientDto {
}

export class SplitReleaseDto {
// Unbounded recipients: the contract's `release` iterates every recipient
// (one token transfer each) — a large split exceeds Soroban's
// per-transaction resource limits and fails on-chain (#581, #15). Cap at a
// size that stays within the contract's budget.
@ApiProperty({ type: [SplitRecipientDto] })
@ArrayMinSize(1)
@ArrayMaxSize(50)
@ValidateNested({ each: true })
@Type(() => SplitRecipientDto)
recipients: SplitRecipientDto[];
Expand Down
3 changes: 3 additions & 0 deletions src/teams/dto/create-team.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ApiProperty } from '@nestjs/swagger';
import { Transform, Type } from 'class-transformer';
import {
ArrayMaxSize,
ArrayMinSize,
IsNotEmpty,
IsNumber,
Expand Down Expand Up @@ -34,6 +35,7 @@ export class TeamMemberSplitDto {
export class UpdateTeamSplitsDto {
@ApiProperty({ type: [TeamMemberSplitDto] })
@ArrayMinSize(1)
@ArrayMaxSize(50)
@ValidateNested({ each: true })
@Type(() => TeamMemberSplitDto)
splits: TeamMemberSplitDto[];
Expand All @@ -56,6 +58,7 @@ export class CreateTeamDto {

@ApiProperty({ type: [TeamMemberSplitDto] })
@ArrayMinSize(1)
@ArrayMaxSize(50)
@ValidateNested({ each: true })
@Type(() => TeamMemberSplitDto)
members: TeamMemberSplitDto[];
Expand Down