Repository navigation
fix(sync): upsertIssueRecord is an atomic INSERT ON CONFLICT — closes the race - #671
Open
yggdrasilworld wants to merge 1 commit into
Open
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
… the race The read-then-save let two concurrent syncs both find no row and both INSERT, so one hit the unique githubIssueId constraint. The atomic INSERT ... ON CONFLICT DO UPDATE makes the write race-safe; the stale-check above still guards the update path. Resolves MergeFi#562
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
findIssueByGithubIdOrNull→save(create)let two concurrent syncs both find no row and both INSERT → one hit the uniquegithubIssueIdconstraint (regression of #376).Fix
Atomic
INSERT ... ON CONFLICT DO UPDATE— the write's race-safe; the stale-check above still guards the update path.Resolves #562