Skip to content

fix(api): GET /milestones + /maintenance-pools load the relations the UI renders #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yggdrasilworld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): GET /milestones + /maintenance-pools load the relations the UI renders #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/maintenance-pool/maintenance-pool.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ export class MaintenancePoolService {
}

async list(): Promise<MaintenancePool[]> {
return this.poolRepo.find();
// Load repository/sponsor/escrow — the frontend's adaptMaintenancePool
// needs them; a bare find() returned rows with no relations (#591).
return this.poolRepo.find({
relations: ['repository', 'createdBy', 'escrow'],
});
}
}
7 changes: 6 additions & 1 deletion src/milestones/milestones.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,12 @@ export class MilestonesService {
}

async list(): Promise<Milestone[]> {
return this.milestoneRepo.find();
// Load the relations the frontend's adaptMilestone renders — repository
// (org/repo display), sponsor, escrow (fund status), issues (the linked
// issues). A bare find() returned empty rows (#591).
return this.milestoneRepo.find({
relations: ['repository', 'sponsor', 'escrow', 'issues'],
});
}

allocateBudget(id: string) {
Expand Down