Repository navigation
fix(milestones): a milestone can pay out more than its first issue - #675
Open
yggdrasilworld wants to merge 2 commits into
Open
yggdrasilworld wants to merge 2 commits into
yggdrasilworld wants to merge 2 commits into
Conversation
… UI renders Both list() were bare find() — no relations, so the frontend's adaptMilestone/adaptMaintenancePool got empty rows (no repository, sponsor, escrow, issues). Resolves MergeFi#591
resolveIssue asserted status->IN_PROGRESS on every call — the first resolve moved FUNDED->IN_PROGRESS, so the second resolve hit IN_PROGRESS->IN_PROGRESS which isn't a valid transition and threw. Only transition when not already IN_PROGRESS. Resolves MergeFi#578
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
resolveIssueassertedstatus->IN_PROGRESSon every call — the first resolve moved FUNDED->IN_PROGRESS, so the second hit IN_PROGRESS->IN_PROGRESS (invalid) and threw. A milestone could only ever pay ONE issue.Fix
Only transition when not already IN_PROGRESS.
Resolves #578