Skip to content

fix(reputation): the reads are public, not self-view-only + recompute throttle #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yggdrasilworld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(reputation): the reads are public, not self-view-only + recompute throttle #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/reputation/reputation.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
UseGuards,
} from '@nestjs/common';
import { ApiBearerAuth, ApiQuery, ApiTags } from '@nestjs/swagger';
import { Throttle } from '@nestjs/throttler';
import { ReputationService } from './reputation.service';
import { JwtAuthGuard } from '../auth/guards/jwt-auth.guard';
import { CurrentUser } from '../common/decorators/current-user.decorator';
Expand All @@ -35,6 +36,10 @@ export class ReputationController {

@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
// Unthrottled, every call ran the multi-join stats SQL AND inserted a row —
// ~170k snapshots/day from one user (#584). Tight limit + the service skips
// the insert when nothing changed.
@Throttle({ long: { limit: 10, ttl: 3_600_000 } })
@Post(':userId/recompute')
recompute(
@Param('userId', new ParseUUIDPipe()) userId: string,
Expand All @@ -47,11 +52,10 @@ export class ReputationController {
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@Get(':userId')
latest(
@Param('userId', new ParseUUIDPipe()) userId: string,
@CurrentUser() user: AuthenticatedUser,
) {
this.assertOwner(user, userId);
latest(@Param('userId', new ParseUUIDPipe()) userId: string) {
// Reputation is a contributor's public track record — a sponsor or
// maintainer needs to read it before assigning a bounty/team (#583).
// Any authenticated user may read; only recompute stays owner-gated.
return this.reputationService.getLatest(userId);
}

Expand All @@ -66,11 +70,11 @@ export class ReputationController {
@ApiQuery({ name: 'offset', required: false })
history(
@Param('userId', new ParseUUIDPipe()) userId: string,
@CurrentUser() user: AuthenticatedUser,
@Query('limit') limit?: string,
@Query('offset') offset?: string,
) {
this.assertOwner(user, userId);
// Public read — sponsors/maintainers see a contributor's track record
// before assigning work (#583). Only recompute is owner-gated.
return this.reputationService.history(userId, {
limit: parseOptionalInt(limit),
offset: parseOptionalInt(offset),
Expand Down