Skip to content

fix(reputation): recompute skips the insert when stats are unchanged #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yggdrasilworld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(reputation): recompute skips the insert when stats are unchanged #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/reputation/reputation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class ReputationService {
this.paymentRepo,
);

const snapshot = this.snapshotRepo.create({
const fields = {
userId,
totalEarnings: stats.lifetimeEarnings.toFixed(7),
mergedPrCount: stats.mergedCount,
Expand All @@ -43,8 +43,28 @@ export class ReputationService {
onTimeDeliveryPercentage: stats.onTimeDeliveryPercentage.toFixed(2),
languages: stats.languages,
orgsContributedTo: stats.orgs,
};

// Skip the insert when nothing changed — an unthrottled recompute could
// otherwise append a row per call (~170k/day for one user, #584). If the
// stats match the latest snapshot, return it instead of a duplicate.
const latest = await this.snapshotRepo.findOne({
where: { userId },
order: { computedAt: 'DESC' },
});
return this.snapshotRepo.save(snapshot);
if (
latest &&
latest.totalEarnings === fields.totalEarnings &&
latest.mergedPrCount === fields.mergedPrCount &&
latest.openBountiesClaimed === fields.openBountiesClaimed &&
latest.completionRate === fields.completionRate &&
latest.avgReviewTimeHours === fields.avgReviewTimeHours &&
latest.onTimeDeliveryPercentage === fields.onTimeDeliveryPercentage
) {
return latest;
}

return this.snapshotRepo.save(this.snapshotRepo.create(fields));
}

async getLatest(userId: string): Promise<ReputationSnapshot | null> {
Expand Down