Repository navigation
fix(entities): remove the duplicate Index import + redundant index decorator - #687
Open
yggdrasilworld wants to merge 4 commits into
Open
yggdrasilworld wants to merge 4 commits into
yggdrasilworld wants to merge 4 commits into
Conversation
…others splitRelease returned raw Payment[] — a loaded payment.escrow relation carried Escrow.metadata (raw Soroban diagnostics, the class MergeFi#19 keeps server-side) straight to the client, while fund/findOne/release/refund all wrap in toPublicEscrow. Added toPublicPayment — strips the relation's metadata — and applied it. Resolves MergeFi#91
…corator team-member-split imported Index twice (a duplicate-import lint/compile error) and declared two @Index decorators naming the same teamId index (IDX_team_member_splits_teamId + IDX_team_member_splits_team_id). Deduped — single import, single index.
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Same stacked-merge corruption as the sibling branch — overlapping returns in escrow.service.ts and sponsors.controller.ts, unclosed blocks in github-webhooks.service.spec.ts. Kept the u64 invoke variant and the validatePage helper (ParseIntPipe already supplies numbers). Spec sync: fund() callerUserId arg, releasePartial manager arg, lowercase role enums, dto-shaped controller calls, checksum-valid fixtures, a StrKey stub in the jest mock, and the FundEscrowDto.deadline IsDateString→IsDate fix (the @type transform made IsDateString unreachable for valid input — every request carrying a deadline 400'd).
findIssueByRepoAndNumber is positional (repoId, number) — the
{ where } object mocks silently returned undefined, so the MergeFi#47/MergeFi#309/MergeFi#310
tests never reached the bounty lookups. 36/36 pass.
Author
|
Verification — tests run (real jest, this PR's head)
Same stacked-merge corruption repaired as the sibling branches ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
team-member-split.entity.tsimportedIndextwice (a duplicate-import compile/lint error) and declared two@Indexdecorators naming the sameteamIdindex (IDX_team_member_splits_teamId+IDX_team_member_splits_team_id).Fix
Deduped — single
Indeximport, single index decorator.