Repository navigation
fix(milestones): deallocate stays open while paused — allocated funds were frozen - #631
Open
yggdrasilworld wants to merge 2 commits into
Open
yggdrasilworld wants to merge 2 commits into
yggdrasilworld wants to merge 2 commits into
Conversation
… were frozen A pause() was meant to block NEW risky ops (allocate/release/contribute) but keep recovery paths open — its own doc says so. deallocate was pause- blocked though, so during a pause a sponsor couldn't un-allocate funds back to remaining_budget (or refund on a closed milestone) — allocated funds were frozen. Deallocate is a recovery path; it no longer checks is_paused. Resolves MergeFi#530 Tests: updated test_deallocate_blocked_while_paused + the pause-coverage test to assert the recovery-path semantics. Note: couldn't run cargo test — the workspace needs rustc 1.95 (installed: 1.92); CI verifies.
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Ready for review — a fund-freeze: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What — a fund-freeze
pause()was meant to block NEW risky ops (allocate/release/contribute) but keep recovery paths open — its own doc says so.deallocatewas pause-blocked though, so during a pause a sponsor couldn't un-allocate funds back toremaining_budget(or trigger the refund on a closed milestone) — allocated funds were frozen.Fix
deallocateis a recovery path — it no longer checksis_paused. Tests updated to assert the recovery-path semantics.Note:
cargo testcouldn't run locally (workspace needs rustc 1.95, installed 1.92) — CI verifies.Resolves #530
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e