Repository navigation
test: cover the untested error-paths - #632
Closed
yggdrasilworld wants to merge 3 commits into
Closed
yggdrasilworld wants to merge 3 commits into
yggdrasilworld wants to merge 3 commits into
Conversation
… were frozen A pause() was meant to block NEW risky ops (allocate/release/contribute) but keep recovery paths open — its own doc says so. deallocate was pause- blocked though, so during a pause a sponsor couldn't un-allocate funds back to remaining_budget (or refund on a closed milestone) — allocated funds were frozen. Deallocate is a recovery path; it no longer checks is_paused. Resolves MergeFi#530 Tests: updated test_deallocate_blocked_while_paused + the pause-coverage test to assert the recovery-path semantics. Note: couldn't run cargo test — the workspace needs rustc 1.95 (installed: 1.92); CI verifies.
- escrow MergeFi#516: initialize rejects treasury == contract (InvalidTreasury) - milestones MergeFi#518: same InvalidTreasury; MergeFi#519: deallocate an unallocated issue (IssueNotAllocatedForDeallocate); MergeFi#525: get_oracle returns the configured oracle - maintenance-pool MergeFi#521: InvalidTreasury; MergeFi#522: reclaim_deposit rejects a different sponsor (NotDepositSponsor) Note on MergeFi#517/MergeFi#520/MergeFi#523/MergeFi#524 (ArithmeticOverflow + DepositCountOverflow): those checked_add paths are defensive — the token's i128 supply bounds escrow.amount / contribution.amount / deposit-count, so a caller can't push them past overflow through the public API. No honest test can trigger them; flagged here rather than writing a fake one.
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests for the error-paths that were genuinely reachable but uncovered:
initializerejects treasury == contract (InvalidTreasury)InvalidTreasury; milestones: the Error::IssueNotAllocatedForDeallocate path has no test #519 —deallocatean unallocated issue (IssueNotAllocatedForDeallocate); milestones::get_oracle has no test #525 —get_oraclereturns the configured oracleInvalidTreasury; maintenance-pool: the Error::NotDepositSponsor path has no test #522 —reclaim_depositrejects a different sponsor (NotDepositSponsor)Honest note on #517/#520/#523/#524
The
ArithmeticOverflow+DepositCountOverflowchecked_addpaths are defensive — the token'si128supply boundsescrow.amount/contribution.amount/deposit-count, so a caller can't push them past overflow through the public API. No honest test can trigger them; flagged rather than writing a fake one.Resolves #516 #518 #519 #521 #522 #525 (the triggerable error-paths)
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e