Skip to content

docs+clippy: fix the stale doc-claims and inconsistent digit-grouping #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yggdrasilworld wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs+clippy: fix the stale doc-claims and inconsistent digit-grouping #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
634d823
fix(milestones): deallocate stays open while paused — allocated funds…
yggdrasilworld Oct 14, 2026
e848100
test: cover the untested error-paths
yggdrasilworld Oct 14, 2026
8f6f15c
docs+clippy: fix the stale doc-claims and inconsistent digit-grouping
yggdrasilworld Oct 14, 2026
6e2e1b7
test: contract-path imports + pause/pool expectations
yggdrasilworld Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions contracts/escrow/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#![cfg(test)]

use super::*;
use crate::contract::{EscrowContract, EscrowContractClient};
use soroban_sdk::{
testutils::{storage::Persistent as _, Address as _, Ledger},
token, vec, Address, Env,
Expand Down Expand Up @@ -52,6 +53,21 @@ fn test_getters_return_not_initialized_before_initialize() {
assert_eq!(client.try_get_max_sponsors(), Err(Ok(Error::NotInitialized)));
}

#[test]
fn test_initialize_rejects_treasury_equal_to_contract() {
// #516 — InvalidTreasury: the treasury must not be the contract itself.
let env = Env::default();
env.mock_all_auths();
let contract_id = env.register(EscrowContract, ());
let client = EscrowContractClient::new(&env, &contract_id);
let admin = Address::generate(&env);
let oracle = Address::generate(&env);

let result = client.try_initialize(&admin, &oracle, &contract_id, &500u32, &None);
assert_eq!(result, Err(Ok(Error::InvalidTreasury)));
}


#[test]
fn test_initialize_rejects_fee_bps_above_10000() {
let env = Env::default();
Expand Down Expand Up @@ -369,8 +385,8 @@ fn test_adversarial_ordering_resistance() {
let admin = Address::generate(&env);
let oracle = Address::generate(&env);
let treasury = Address::generate(&env);
let contract_id = env.register(crate::EscrowContract, ());
let client = crate::EscrowContractClient::new(&env, &contract_id);
let contract_id = env.register(crate::contract::EscrowContract, ());
let client = crate::contract::EscrowContractClient::new(&env, &contract_id);

// Initialize with 0% fee to simplify fraction/dust calculations
client.initialize(&admin, &oracle, &treasury, &0u32, &None);
Expand Down Expand Up @@ -435,8 +451,8 @@ fn test_large_split_distributes_dust_by_largest_remainder() {
let admin = Address::generate(&env);
let oracle = Address::generate(&env);
let treasury = Address::generate(&env);
let contract_id = env.register(crate::EscrowContract, ());
let client = crate::EscrowContractClient::new(&env, &contract_id);
let contract_id = env.register(crate::contract::EscrowContract, ());
let client = crate::contract::EscrowContractClient::new(&env, &contract_id);
// 0% fee so the whole total is distributable.
client.initialize(&admin, &oracle, &treasury, &0u32, &None);

Expand Down Expand Up @@ -2152,6 +2168,7 @@ fn test_set_treasury_updates_treasury_address() {
#[test]
fn test_set_treasury_requires_admin_auth() {
let env = Env::default();
env.mock_all_auths();
let (_, admin, _treasury, client) = setup(&env);

let new_treasury = Address::generate(&env);
Expand Down
Loading