Repository navigation
fix(dashboard): validate tab query param to active or completed - #727
Open
dezzy-music wants to merge 1 commit into
Open
dezzy-music wants to merge 1 commit into
dezzy-music wants to merge 1 commit into
Conversation
|
@dezzy-music is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #692
Summary
ContributorDashboardClientpreviously castsearchParams.get("tab")directly to"active" | "completed". Visiting/dashboard/contributor?tab=foo(or any mistyped/unrecognized tab parameter) caused no tab inTabsto be selected, resulting in broken keyboard navigation (tabIndex=0missing) and neither panel rendering.Changes
tabsearch parameter against the supported set (completedvsactive), falling back safely toactive.ContributorDashboardClient.test.tsxcovering fallback on missingtab, selection on?tab=completed, and safe degradation toactiveon invalid/unknown?tab=foovalues.