Skip to content

fix(a11y): allow visible repo and issue to form pipeline card accessible name #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dezzy-music wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): allow visible repo and issue to form pipeline card accessible name #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/app/dashboard/maintainer/PipelineBoard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,23 @@ describe("PipelineBoard / escrow-stat consistency (#88)", () => {
expect(columnStatuses.has(status)).toBe(false);
}
});

it("does not override visible content with aria-label, allowing screen readers to announce repo and issue (#694)", () => {
const bounty = makeBounty({
id: "bounty-42",
org: "StellarOrg",
repo: "stellar-core",
issueNumber: 99,
title: "Consensus round timeout fix",
reward: 1000,
asset: "USDC",
status: "open",
});
render(<PipelineBoard bounties={[bounty]} />);

const link = screen.getByRole("link", { name: /stellarorg\/stellar-core #99/i });
expect(link).toBeInTheDocument();
expect(link).not.toHaveAttribute("aria-label");
});
});

1 change: 0 additions & 1 deletion src/app/dashboard/maintainer/PipelineBoard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ function PipelineColumn({
key={b.id}
href={`/issues/${b.id}`}
title={b.title}
aria-label={`${b.title}, ${formatCurrency(b.reward, b.asset)}`}
className="block rounded-xl border border-slate-200 bg-white p-3 shadow-sm transition-colors hover:border-indigo-300 focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-indigo-500 dark:border-slate-800 dark:bg-slate-900 dark:hover:border-indigo-700"
>
<p className="truncate text-xs text-slate-400 dark:text-slate-500">
Expand Down