Repository navigation
fix: don't compare bounty rewards across mixed USDC/XLM assets - #732
Open
smartcalsystems-sketch wants to merge 1 commit into
Open
smartcalsystems-sketch wants to merge 1 commit into
smartcalsystems-sketch wants to merge 1 commit into
Conversation
|
@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
filterBounties'sminReward/maxRewardbounds andsortBounties'sreward-desc/reward-ascsorts comparebounty.rewardas a raw number regardless of asset. Since USDC and XLM aren't 1-for-1 (1 XLM is roughly $0.10, not $1), a 500 XLM bounty (~$50) sorts above a 400 USDC one, andminReward=100keeps a 100 XLM bounty as if it were $100. The asset facet is separate from the reward bound/sort, so the default "any asset" view silently mixes units.Fix
Added a
hasMixedAssetscheck: when the asset facet is"all"and the candidate set actually spans more than one asset, the reward range filter is ignored and reward-based sorting is skipped (falls back to the existing order) rather than producing a misleading cross-currency comparison. When a single asset is selected, or the data happens to be single-asset anyway, behavior is unchanged — this only changes the specific case where comparison would be meaningless.I considered the alternative in the issue (normalize via a displayed conversion rate) but there's no exchange-rate source anywhere in this codebase today, and introducing one just for comparison purposes felt like a bigger, separate change (and a staleness/accuracy liability) versus just not comparing incomparable things. Happy to go that route instead if there's already a rate source I missed.
Testing
filterBountiesandapplyBountyQuery's sort, plus a same-asset-data regression check.bounty-query.test.tssuite: 26/26 passing (22 pre-existing + 4 new), zero regressions.tsc --noEmitandeslintclean on both changed files.Closes #613