Repository navigation
fix: deadline-asc sort no longer ranks expired bounties as soonest - #733
Open
smartcalsystems-sketch wants to merge 1 commit into
Open
smartcalsystems-sketch wants to merge 1 commit into
smartcalsystems-sketch wants to merge 1 commit into
Conversation
|
@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
deadline-ascsorted by raw timestamp, so an already-expired deadline (the smallest timestamp) ranked first. A contributor choosing "Deadline: soonest" would see bounties they can no longer complete ahead of urgent-but-still-open ones.Fix
Captures
nowonce per sort call, classifies each deadline as expired or not, and ranks every non-expired deadline before every expired one. Within each group, ordering is still ascending by timestamp (soonest-upcoming first among open bounties; longest-expired first among expired ones). Bounties with no deadline are unaffected and still sort last, as before.Testing
bounty-query.test.tssuite: 23/23 passing (22 pre-existing + 1 new), zero regressions.tsc --noEmitandeslintclean on both changed files.Closes #703