Skip to content

fix: 'View all N' pipeline links now filter to that column's status - #739

Open
smartcalsystems-sketch wants to merge 1 commit into
MergeFi:mainfrom
smartcalsystems-sketch:fix-pipeline-viewall-link-status-693
Open

smartcalsystems-sketch wants to merge 1 commit into
MergeFi:mainfrom
smartcalsystems-sketch:fix-pipeline-viewall-link-status-693

Conversation

@smartcalsystems-sketch

Copy link
Copy Markdown

Problem

Columns cap at 8 cards and show "View all {n} in Bounty pipeline" → /issues. The link carries no status, and /issues's status facet only supported all/open/in_review, so there was no way to view all claimed, funded, or awaiting payout (merged) bounties the column was summarising, even if the link had carried the status.

Fix

  • Expanded STATUS_VALUES in bounty-query.ts to cover every status PipelineBoard renders a column for: open, funded, claimed, in_review, merged.
  • Threaded each column's status into PipelineColumn and used it to build the link as /issues?status=<status> instead of a bare /issues.
  • filterBounties already compares b.status against query.status generically, so no change was needed there — it works for the new values automatically.

Scope note: the three status pills rendered on /issues itself (All/Open/In review) are unchanged. Visiting /issues?status=funded (etc.) filters correctly, it just won't highlight a pill — same as how the reward-range filters today have no corresponding pill either. Adding pills for every pipeline status felt like a separate, larger UI decision outside what this issue asks for; happy to add them too if that's wanted.

Testing

  • Added 2 tests: a column's "View all N" link carries ?status=<that column's status>, and this holds for multiple overflowing columns simultaneously (not just the default facet values).
  • Full PipelineBoard.test.tsx: 9/9 passing (7 pre-existing + 2 new).
  • bounty-query.test.ts + issues/page.test.tsx: 37/37 passing, zero regressions from the STATUS_VALUES change.
  • tsc --noEmit and eslint clean on all changed files.

Closes #693

…loses MergeFi#693)

Columns capped at 8 cards linked to a bare /issues regardless of which
column overflowed, and the status facet only supported all/open/
in_review -- so there was no way to view all claimed, funded, or
awaiting-payout (merged) bounties a column was summarising even if the
link had carried the status.

Expanded STATUS_VALUES to cover every status PipelineBoard renders a
column for (open, funded, claimed, in_review, merged), and threaded
each column's status into its 'View all' link as ?status=<status>.
filterBounties already compares by raw status value generically, so no
change was needed there. The three status pills on /issues itself are
unchanged (still all/open/in_review) -- visiting with one of the new
status values filters correctly, it just won't highlight a pill, same
as the existing reward-range filters have no corresponding pill either.
@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PipelineBoard's 'View all N' link goes to the unfiltered board, which can't filter to that column's status

1 participant