Repository navigation
fix: 'View all N' pipeline links now filter to that column's status - #739
Open
smartcalsystems-sketch wants to merge 1 commit into
Open
smartcalsystems-sketch wants to merge 1 commit into
smartcalsystems-sketch wants to merge 1 commit into
Conversation
…loses MergeFi#693) Columns capped at 8 cards linked to a bare /issues regardless of which column overflowed, and the status facet only supported all/open/ in_review -- so there was no way to view all claimed, funded, or awaiting-payout (merged) bounties a column was summarising even if the link had carried the status. Expanded STATUS_VALUES to cover every status PipelineBoard renders a column for (open, funded, claimed, in_review, merged), and threaded each column's status into its 'View all' link as ?status=<status>. filterBounties already compares by raw status value generically, so no change was needed there. The three status pills on /issues itself are unchanged (still all/open/in_review) -- visiting with one of the new status values filters correctly, it just won't highlight a pill, same as the existing reward-range filters have no corresponding pill either.
|
@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Columns cap at 8 cards and show "View all {n} in Bounty pipeline" →
/issues. The link carries no status, and/issues's status facet only supportedall/open/in_review, so there was no way to view all claimed, funded, or awaiting payout (merged) bounties the column was summarising, even if the link had carried the status.Fix
STATUS_VALUESinbounty-query.tsto cover every statusPipelineBoardrenders a column for:open,funded,claimed,in_review,merged.statusintoPipelineColumnand used it to build the link as/issues?status=<status>instead of a bare/issues.filterBountiesalready comparesb.statusagainstquery.statusgenerically, so no change was needed there — it works for the new values automatically.Scope note: the three status pills rendered on
/issuesitself (All/Open/In review) are unchanged. Visiting/issues?status=funded(etc.) filters correctly, it just won't highlight a pill — same as how the reward-range filters today have no corresponding pill either. Adding pills for every pipeline status felt like a separate, larger UI decision outside what this issue asks for; happy to add them too if that's wanted.Testing
?status=<that column's status>, and this holds for multiple overflowing columns simultaneously (not just the default facet values).PipelineBoard.test.tsx: 9/9 passing (7 pre-existing + 2 new).bounty-query.test.ts+issues/page.test.tsx: 37/37 passing, zero regressions from theSTATUS_VALUESchange.tsc --noEmitandeslintclean on all changed files.Closes #693