Repository navigation
Conversation
A number in --rules is the admitted relative difference |ref - cur| / (1 + |ref|) for that column, not scaled by --factor. It is meant for plevel and e_o, which GPU and CPU runs of ICON reproduce only to the last float32 bit, or to about 1e-5 for SYNOP plevel in mixed precision. Values missing in both files now pass a rule column, and a rule violation in the reports is no longer overwritten by the observation check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
muellch
force-pushed
the
fof_rule_tolerance
branch
from
November 12, 2026 16:18
2842ff6 to
2eb4b47
Compare
Collaborator
|
Thanks for pointing out this short coming of the current implementation. Nevertheless I think it is not very clean to mix tolerances with the rules for labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. ICON's fof check compares every variable except
veri_dataexactly.plevelande_oof PILOT and SYNOP come from the model state, so CPU and GPU runs agree only to the last float32 bit, and SYNOPplevelin mixed precision to about 1e-5. The GPU bug fixed in icon-nwp!2385 shifted them by 3e-4 to 1e-3, so a small tolerance separates noise from a real error.What. A number in
--rulesis now the admitted relative difference |ref - cur| / (1 + |ref|) for that column, not scaled by--factor; a list keeps its meaning. Two small fixes come along: values missing in both files pass a rule column, and a rule violation in the reports is no longer overwritten by the observation check.Test. New unit tests in
tests/util/test_fof_rules.py. On the full ICONmch_kenda-ch1fof files with"plevel": 5e-5, "e_o": 1e-6, the fixed GPU run passes AIREP, DRIBU, PILOT and SYNOP against CPU in double and mixed precision; the GPU run with the bug still fails PILOT and SYNOP.🤖 Generated with Claude Code