Repository navigation
fix: add detect-secrets baseline and triage cargo-audit advisories - #1246
Merged
nanaf6203-bit merged 1 commit intoSep 30, 2026
Conversation
…ettaChain#1211, MettaChain#1203) Commit a committed .secrets.baseline so the pre-commit detect-secrets hook passes deterministically: findings from a full tracked-file scan were audited (6 false positives: dev-only compose credentials, a usage placeholder and public Substrate test addresses) and documented in .secrets-audit-justifications.md together with the baseline workflow. Ignore the pinned-transitive h2 (RUSTSEC-2026-0258) and rustls-webpki (RUSTSEC-2026-0098) advisories in audit.toml with per-entry justification, per the approach accepted in the issue, and record the triage in AUDIT_LOG.md. Closes MettaChain#1211 Closes MettaChain#1203 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@DanielCharis1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the two issues assigned to @DanielCharis1 with a single, low-risk change:
#1211 — missing
.secrets.baselinebreaks the detect-secrets hook.secrets.baseline(generated with detect-secrets v1.4.0, matching the hook rev) sopre-commit run detect-secretspasses deterministically instead of erroring / running un-baselined.is_secret: false— they are false positives:docker-compose.yml(lines 42, 68): local-only dev Postgres credential (propchain123)scripts/archive-events.sh(line 9): usage-docstring placeholderpostgres://user:pass@hostscripts/test_accounts.rs(lines 8–10): well-known public Substrate Alice/Bob/Charlie addresses (public keys, not seeds).secrets-audit-justifications.md.#1203 — cargo-audit advisories h2 0.3.27 / rustls-webpki 0.101.7
Per the issue's proposed approach ("pin older transitive versions deliberately with audit.toml ignore with justification"):
audit.tomlnow explicitly ignores RUSTSEC-2026-0258 (h2 0.3.27) and RUSTSEC-2026-0098 (rustls-webpki 0.101.7/0.102.8), each with an inline justification: both are pinned transitively by the substrate/ink toolchain; the fixed versions require a hyper/rustls major bump out of scope for the ink! 5.1 workspace, and no workspace code path exposes the vulnerable surfaces (no HTTP/2 termination, no rustls client parsing untrusted certs). Re-evaluation notes included.AUDIT_LOG.md; pre-existing ignores (RUSTSEC-2026-0104, RUSTSEC-2026-0002) unchanged.Test plan
git ls-fileswith the hook's detect-secrets version and auditedaudit.toml/.secrets.baselineTOML+JSON validitycargo audit/cargo-deny checkshould report zero unignored advisories (deny.toml license-key cleanup is tracked separately and intentionally out of scope)Closes #1211
Closes #1203