PackageManager.FindPackages: clarify user scope and parameter formats - #2531
Open
John Kennedy (GrantMeStrength) wants to merge 1 commit into
Open
John Kennedy (GrantMeStrength) wants to merge 1 commit into
John Kennedy (GrantMeStrength) wants to merge 1 commit into
Conversation
Addresses community feedback (MicrosoftDocs/windows-dev-docs#5503): 1. FindPackages() — fix incorrect description ('specified family' copied from sibling overload); add note that results span all users. 2. FindPackages(String familyName) — add NOTE callout clarifying that packageFamilyName = Package.Id.FamilyName (not Name or FullName); wrong format silently returns empty collection. 3. FindPackages(String name, String publisher) — empty Remarks filled in: - All-users scope (not current user) now stated explicitly - packageName = Package.Id.Name (not FullName) - packagePublisher = Package.Id.Publisher (full X.500 DN, not PublisherId) - Recommend FindPackages(FamilyName) as simpler alternative Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
prmerger-automator
Bot
added
do-not-merge
John Kennedy (GrantMeStrength)
requested review from
drew batchelor (drewbatgit) and
Jon Wiswall (jonwis)
April 7, 2026 16:33
John Kennedy (GrantMeStrength)
requested
a balanced review from Copilot
and removed request for
drew batchelor (drewbatgit)
September 16, 2026 15:50
Copilot started reviewing on behalf of
John Kennedy (GrantMeStrength)
September 16, 2026 15:51
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The parameterless overload links to a filtered three-parameter method instead of the equivalent per-user overload.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Clarifies PackageManager.FindPackages scope and parameter formats.
Changes:
- Corrects the parameterless overload description.
- Documents all-user scope and expected package identifiers.
- Adds examples and guidance for avoiding empty results.
File summaries
| File | Description |
|---|---|
packagemanager_findpackages_331793265.md |
Clarifies family-name format. |
packagemanager_findpackages_1597689551.md |
Documents scope and name/publisher formats. |
packagemanager_findpackages_1246181969.md |
Corrects scope description and adds per-user guidance. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ## -remarks | ||
| This method requires administrative privileges. Otherwise, an **AccessDeniedException** is thrown. | ||
|
|
||
| This method returns packages installed for **all users** on the device. To retrieve packages for a specific user only, use [FindPackagesForUser](packagemanager_findpackagesforuser_292215772.md). |
Contributor
|
Hey Howard Kapustein (@DrusTheAxe) or sarjanas-msft can you check this? My recollection is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MicrosoftDocs/windows-dev-docs#5503
Community feedback: the
FindPackagesoverloads don't explain whether they return packages for all users or just the current user, and thepackageName/packageFamilyNameparameter formats are ambiguous — passing the wrong format silently returns an empty collection.Changes
FindPackages()FindPackagesForUserfor per-user queriesFindPackages(String familyName)[!NOTE]clarifyingpackageFamilyName=Package.Id.FamilyName(e.g.Microsoft.WindowsCalculator_8wekyb3d8bbwe), notId.NameorId.FullNameFindPackages(String name, String publisher)FindPackagesForUserfor per-user queriespackageName=Package.Id.Name(notFullName)packagePublisher=Package.Id.Publisher(full X.500 DN, notPublisherId)FindPackages(FamilyName)as a simpler, less error-prone alternative