Skip to content

Support Gradle's Isolated Projects feature in EnhancedPluginAdditions#rootProjectDirectory() - #30

Open
PaintNinja wants to merge 1 commit into
MinecraftForge:mainfrom
PaintNinja:fix/isolated-projects-settings-dir
Open

Support Gradle's Isolated Projects feature in EnhancedPluginAdditions#rootProjectDirectory()#30
PaintNinja wants to merge 1 commit into
MinecraftForge:mainfrom
PaintNinja:fix/isolated-projects-settings-dir

Conversation

@PaintNinja

Copy link
Copy Markdown
Contributor

Prerequisite for MinecraftForge/ForgeGradle#1083

Using the isolated project API recommended by Gradle instead of grabbing the settings directory as this is a more direct replacement - there are edge-cases where the settings directory may differ from the root project's directory.

@PaintNinja PaintNinja added the enhancement New feature or request label Aug 19, 2026
@Jonathing

Copy link
Copy Markdown
Member

Has that isolated project API changed since 9.0? I'd like for GU to maintain the back compat with it until 4.0.

@LexManos

Copy link
Copy Markdown
Member

Its still incubating, but according to the docs its existed since 8.8, so we should be fine.

@PaintNinja

PaintNinja commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

I've checked the javadocs for 9.0.0 and current (9.7.1 at the time of writing) and the getIsolated().getRootProject() methods haven't changed, so this PR doesn't break compat with Gradle 9.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants