Skip to content

Reject input whose selected Credential was deleted - #863

Merged
SaladDay merged 2 commits into
mainfrom
fix/input-deleted-credential
Oct 25, 2026
Merged

SaladDay merged 2 commits into
mainfrom
fix/input-deleted-credential

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

A Session whose frozen MCP Credential binding names a Credential that was deleted (or whose Vault was deleted) now rejects new message input with the same 400 selection error that Session creation returns for an absent Credential, instead of admitting a Turn that fails at dispatch.

  • vaults.Service.CheckMCPCredentials reads metadata only, reusing FindMCPCredentials.
  • Worker.SubmitInputs runs the check for message batches on a Session with no active Turn, before and outside the admission transaction.
  • A retry of a batch the Session already admitted still replays (sessions.Service.InputAdmitted).
  • The ledger line for this difference is removed; vaults.md and the sessions-events.md input error table describe the behavior (EN + ZH).

Checks: focused go test for vaults, execution, sessions, api and the new integration test mcp_credential_input_test.go.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@SaladDay
SaladDay force-pushed the fix/input-deleted-credential branch from 268ff48 to ee239ee Compare October 25, 2026 02:48
@SaladDay
SaladDay merged commit 97679bb into main Oct 25, 2026
1 check passed
@SaladDay
SaladDay deleted the fix/input-deleted-credential branch October 25, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant