Repository navigation
Keep the console route when skipping to content - #867
Merged
Merged
Conversation
The skip link and the console router both use the URL fragment, so following #main-content sent every page to Overview and dropped its parameters. The link now moves focus to the main element without navigating. Closes #421.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip link and the console router both use the URL fragment, so following
#main-contentsent every page to Overview and dropped its parameters. The link now moves focus to the main element without navigating.Closes #421.
Checks:
pnpm run typecheck. The new Playwright case runs in CI (browsers cannot start on the development server).Need help on this PR? Tag
@codesmith-botwith what you need.