Repository navigation
Stop publishing unused release archives - #869
Merged
Merged
Conversation
The node component omits the CI runner's global pnpm and the minimax component omits better-sqlite3's deps, src and binding.gyp. Neither is loaded at run time. linux-amd64 archives shrink by 4.6 MB (node) and 2.7 MB (minimax) compressed.
The control archives carry the Core, Web and ingress images and the native catalog from the build to the publisher, which pushes the images to GHCR. No install path downloads them, so the publisher no longer uploads them as release assets (337 MB per release).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last size items of #802, measured against v0.0.13-rc.2.
oac-<commit>-linux-{amd64,arm64}.tar.gz:install.sh,install.ps1andoac installfetch theoacbinary,compose.yamland the checksums and pull images from GHCR. The archives are still built, because they carry the Core, Web and ingress images and the native catalog from the build job to the publisher, which pushes the images to GHCR; the publisher just no longer uploads them. Saves 336,667,754 bytes per release (230,149,377 + 106,518,377).nodecomponent no longer carries the CI runner's global pnpm, andminimaxno longer carriesbetter-sqlite3's compiler inputs (deps/with the 9 MiBsqlite3.c,src/,binding.gyp); it loads onlybuild/Release/better_sqlite3.node. Checked on the unpacked rc.2 components: npm and npx run without pnpm; MiniMax Code--version, its compatibility check and a better-sqlite3 insert and select work without the inputs. linux-amd64node61,763,516 → 57,124,910 bytes andminimax23,842,332 → 21,177,411 bytes compressed, about 7.3 MB per installer.codex-code-mode-host(66 MiB) stays: since Ship the Codex code-mode host in the Runtime image #865 Codex's native code mode runs scripts in it.Closes #802.
Checks:
python3 -I scripts/publish-core-release.test.py,python3 -I scripts/core-distribution-manifest.test.py,node --test scripts/build-native-installer.test.mjs scripts/build-native-catalog.test.mjs,bash -n scripts/build-core-distribution.sh. The Windows and macOS node layouts are covered by the omit list but were not unpacked here.Need help on this PR? Tag
@codesmith-botwith what you need.