Repository navigation
Emit Environment pending and ready events - #870
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted Sessions now stream the pinned
agent.session.environment.pendingandagent.session.environment.readyevents, which the ledger listed as a known gap.openai_hostedEnvironment journalspendingin the transaction that starts its initialization andreadyin the one that completes it. Each transition is a conditional update, so retries, a preparation-cache hit and a Core restart never repeat an event.self_hostedEnvironments emit neither. Connected, disconnected and failed are unchanged.readyis not re-emitted before each later Turn as one official Session did, hosted Environments still emitconnected/disconnected, and when the official service emitspendingis unverified.Checks:
go test ./internal/sessions,go vet ./...(services/core),go test ./tests/integration/ ./internal/api/ -run 'Initialization|EnvironmentInputActivity|CreationStream|HostedEnvironment|Event|Stream|Hosted|Environment|Turn'against PostgreSQL.Need help on this PR? Tag
@codesmith-botwith what you need.