Repository navigation
fix(dev-panel): resolve contact IDs from page metadata, not caller names - #49
Merged
chriskehayias merged 1 commit intoOct 10, 2026
Merged
Conversation
ToolService.resolveContactIds now takes (pageId, recordIds) and looks up Table_Name, Primary_Key and Contact_ID_Field server-side via getPageData, validating them with validateColumnName / validateFkPath before they are interpolated. The dev-panel action and ContactRecordsPanel pass the page ID instead of table/column names, so no caller can choose which table the service account reads. Adds hostile-identifier tests. Closes the 2026-10-10 dev-panel-resolvecontactids-caller-identifiers TODO. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
chriskehayias
deleted the
fix/dev-panel-resolve-contact-ids-page-metadata
branch
October 10, 2026 15:45
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolService.resolveContactIds(pageId, recordIds)now looks upTable_Name,Primary_KeyandContact_ID_Fieldserver-side viagetPageData, validating them withvalidateColumnName/validateFkPathbefore interpolation. Returnsnullwhen the page is unknown or has no contact metadata.resolveContactRecordsandContactRecordsPanelpassparams.pageIDinstead of table/column names, matching whatFamilyService.resolveContactIdFromPage's action already does.INDEX.md.Test plan
npm run lintnpm run typechecknpm run test:coverage(2095 passed)🤖 Generated with Claude Code