Repository navigation
fix(addeditfamily): show "No contacts found" when a search comes up empty - #50
Merged
Merged
Conversation
…mpty cmdk's CommandEmpty renders only when the whole Command has zero items, and the "+ New Family" item is always registered once the query is >= 2 characters, so the message never appeared. Replace it with a plain div gated on our own state, and only once the term on screen has actually been searched (tracked as searchedTerm), so it does not flash during the 300 ms debounce. Adds GOTCHA-045. Closes the 2026-09-13 search-empty-state-never-renders TODO. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FamilySearchBar's<CommandEmpty>never rendered: cmdk shows it only when the wholeCommandhas zero items, and the "+ New Family" item is always registered once the query is >= 2 chars.<div>matching the "Searching…" / "Type at least 2 characters" states.searchedTermstate, so the message appears only after the term on screen has been searched. Without that it would flash during the 300 ms debounce whileresultsstill holds the previous term's answer. A failed search shows nothing, as before.INDEX.md.Test plan
npm run lintnpm run typechecknpm run test:coverage(2096 passed)🤖 Generated with Claude Code