Repository navigation
feat(no-access): sign-out form for users with no MP security role - #55
Merged
Merged
Conversation
Sign-in is not role-gated, so a role-less user has a session but, with the UserMenu gone, no way to end it short of the 12 h lifetime. /no-access now carries the same `handleSignOut` form as /session-error. Walked against a production build with the enforced CSP: MP logout, back to /signin, MP login prompt, zero violations. Docs updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sign-in isn't role-gated, so a user with no MP security role gets a session and lands on
/no-access. WithUserMenuremoved (#54), nothing let them end that session before the 12-hour limit./no-accessnow has a Sign out form wired tohandleSignOut, the same pattern as/session-error. The page stays dynamic because it renders under AuthWrapper, so the CSP nonce is present.Verified against a production build with the CSP enforced. Clicking Sign out on
/no-accesswent to MP's logout page, back to the app, through/signin, and stopped at the MP login prompt, so both sessions ended. No CSP violations.lint,typecheckandtest:coveragepass.🤖 Generated with Claude Code