Repository navigation
docs: accuracy pass across CLAUDE.md, README and references - #105
Merged
Merged
Conversation
Verified against the code; fixes factual errors, drift and broken guidance. - CLAUDE.md: $userId example now takes the acting User_ID from requireSecurityRole (was Contact_ID); real Zod v4 differences; accurate coverage thresholds (only proxy.ts is 100%); Discord workflow; npx tsx; sign-out-broadcast; more reference docs. - README: security notice as an advisory table; JWE sessions and the CurrentUserProfile DTO; no hard-coded test/coverage counts; Node 22 minimum; project tree and Documentation links brought up to date; generator sample output consistent; Contributing/Support expanded. - Node 22 minimum: setup.ts check and "engines" in package.json. - References: sanitized worked $filter example; .pick() allowlist; stale counts and line numbers replaced; lockfile CI job runs in parallel; x-nonce header and force-dynamic pages; sql.db.md confirm-first note; TestCoverage.md marked historical; stale vitest.config comments. - Security docs: sign-in advisory affected range + merge-base checks and fix date; direct private-reporting link in SECURITY.md; downstream playbook F3b grep covers src/app/signin/; write-attribution playbook marked superseded in part. - Commands: /audit-deps relocks after any npm install; /release honors --draft/--prerelease/--target. - Provider/shared-actions READMEs: CurrentUserProfile return type, react-server condition, guards.ts, one MP host placeholder everywhere. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every claim in
CLAUDE.md,README.mdand the linked docs was checked against the code; this fixes what was wrong or stale.Errors fixed
CLAUDE.mdvalidation example passedContact_IDas$userId(the audit-log User_ID) — now taken fromrequireSecurityRole.CLAUDE.mdZod note (z.interface()isn't a v4 API) and coverage thresholds ("100%" applied only toproxy.ts).query-syntax.mdworked example interpolated an unsanitized ID into$filter.CurrentUserProfileDTO, stale test/coverage counts removed (Codecov badge + thresholds instead).shared-actions/README.mdreturn type and removed roles/groups text; provider README--conditions=react-server.65a3225— nowmerge-basechecks plus fix date..claudedownstream playbook F3b grep missedsrc/app/signin/./audit-depsallowed a barenpm installwithout relocking;/releaseignored--draft/--prerelease/--target.Behavioral change
scripts/setup.tscheck and"engines": {"node": ">=22"}(lockfile root mirrors it;deps:verifyclean). CI already runs Node 22.Drift / polish
x-nonce, force-dynamic pages,sql.db.mdconfirm-first note,TestCoverage.mdmarked historical, stalevitest.config.mtscomments (comments only).your-instance.ministryplatform.com/ministryplatformapi) everywhere.Test plan
npx vitest run— 85 files, 2034 passed / 3 skippednpm run lint,npx tsc --noEmit,npm run deps:verify🤖 Generated with Claude Code