Skip to content

GEOPY-2965: move tree_levels implementation to grid-apps - #466

Merged
domfournier merged 4 commits into
developfrom
GEOPY-2965
Aug 25, 2026
Merged

GEOPY-2965: move tree_levels implementation to grid-apps#466
domfournier merged 4 commits into
developfrom
GEOPY-2965

Conversation

@domfournier

@domfournier domfournier commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

GEOPY-2965 - Move tree_levels implementation to grid-apps

Depends on MiraGeoscience/grid-apps#89

Copilot AI lite review requested due to automatic review settings August 21, 2026 18:34
@github-actions github-actions Bot changed the title GEOPY-2965 GEOPY-2965: Import tree_levels from grid-apps Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR shifts tree_levels ownership from simpeg_drivers into grid-apps (per GEOPY-2965) and updates dependency pins / generated lockfiles so the driver code can import the shared helper from grid-apps.

Changes:

  • Import tree_levels from grid_apps.utils and remove the local tree_levels implementation.
  • Update grid-apps git ref in pyproject.toml to the GEOPY-2965 ref.
  • Regenerate conda lockfiles to reflect the updated dependency resolution.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
simpeg_drivers/components/meshes.py Removes local tree_levels and uses the implementation provided by grid-apps.
pyproject.toml Updates grid-apps git rev to GEOPY-2965.
py-3.13.conda-lock.yml Regenerated lock; updates resolved packages including grid-apps and geoh5py.
py-3.12.conda-lock.yml Regenerated lock; updates resolved packages including grid-apps and geoh5py.
environments/py-3.13-win-64.conda.lock.yml Regenerated environment lock reflecting updated dependency set for Win/Py3.13.
environments/py-3.13-win-64-dev.conda.lock.yml Regenerated dev environment lock reflecting updated dependency set for Win/Py3.13.
environments/py-3.13-linux-64.conda.lock.yml Regenerated environment lock reflecting updated dependency set for Linux/Py3.13.
environments/py-3.13-linux-64-dev.conda.lock.yml Regenerated dev environment lock reflecting updated dependency set for Linux/Py3.13.
environments/py-3.12-win-64.conda.lock.yml Regenerated environment lock reflecting updated dependency set for Win/Py3.12.
environments/py-3.12-win-64-dev.conda.lock.yml Regenerated dev environment lock reflecting updated dependency set for Win/Py3.12.
environments/py-3.12-linux-64.conda.lock.yml Regenerated environment lock reflecting updated dependency set for Linux/Py3.12.
environments/py-3.12-linux-64-dev.conda.lock.yml Regenerated dev environment lock reflecting updated dependency set for Linux/Py3.12.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml
Comment thread py-3.12.conda-lock.yml
Comment thread py-3.13.conda-lock.yml
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.41%. Comparing base (cc4fba2) to head (ebf5d92).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage    90.40%   90.41%   +0.01%     
===========================================
  Files          113      113              
  Lines         6993     6983      -10     
  Branches       864      862       -2     
===========================================
- Hits          6322     6314       -8     
+ Misses         453      452       -1     
+ Partials       218      217       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/meshes.py 89.28% <100.00%> (+0.76%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

@sebhmg sebhmg changed the title GEOPY-2965: Import tree_levels from grid-apps GEOPY-2965: move tree_levels implementation to grid-apps Aug 24, 2026
@domfournier
domfournier merged commit e14e1a0 into develop Aug 25, 2026
19 checks passed
@domfournier
domfournier deleted the GEOPY-2965 branch August 25, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants