GEOPY-2965: move tree_levels implementation to grid-apps - #466
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts tree_levels ownership from simpeg_drivers into grid-apps (per GEOPY-2965) and updates dependency pins / generated lockfiles so the driver code can import the shared helper from grid-apps.
Changes:
- Import
tree_levelsfromgrid_apps.utilsand remove the localtree_levelsimplementation. - Update
grid-appsgit ref inpyproject.tomlto the GEOPY-2965 ref. - Regenerate conda lockfiles to reflect the updated dependency resolution.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| simpeg_drivers/components/meshes.py | Removes local tree_levels and uses the implementation provided by grid-apps. |
| pyproject.toml | Updates grid-apps git rev to GEOPY-2965. |
| py-3.13.conda-lock.yml | Regenerated lock; updates resolved packages including grid-apps and geoh5py. |
| py-3.12.conda-lock.yml | Regenerated lock; updates resolved packages including grid-apps and geoh5py. |
| environments/py-3.13-win-64.conda.lock.yml | Regenerated environment lock reflecting updated dependency set for Win/Py3.13. |
| environments/py-3.13-win-64-dev.conda.lock.yml | Regenerated dev environment lock reflecting updated dependency set for Win/Py3.13. |
| environments/py-3.13-linux-64.conda.lock.yml | Regenerated environment lock reflecting updated dependency set for Linux/Py3.13. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Regenerated dev environment lock reflecting updated dependency set for Linux/Py3.13. |
| environments/py-3.12-win-64.conda.lock.yml | Regenerated environment lock reflecting updated dependency set for Win/Py3.12. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Regenerated dev environment lock reflecting updated dependency set for Win/Py3.12. |
| environments/py-3.12-linux-64.conda.lock.yml | Regenerated environment lock reflecting updated dependency set for Linux/Py3.12. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Regenerated dev environment lock reflecting updated dependency set for Linux/Py3.12. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #466 +/- ##
===========================================
+ Coverage 90.40% 90.41% +0.01%
===========================================
Files 113 113
Lines 6993 6983 -10
Branches 864 862 -2
===========================================
- Hits 6322 6314 -8
+ Misses 453 452 -1
+ Partials 218 217 -1
🚀 New features to boost your workflow:
|
sebhmg
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2965 - Move tree_levels implementation to grid-apps
Depends on MiraGeoscience/grid-apps#89