Repository navigation
fix(shell): place a tooltip again when it grows after it is shown - #17
Merged
Merged
Conversation
A web font that arrives after the tooltip was placed makes it wider, so the "Zoom in" tooltip ran 2px past the 12px edge in Context Maps' CI and failed the kit's geometry case. The tooltip now observes its own size and places itself again while it is shown. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…p has one The palette test took the first ResizeObserver, which is now the tooltip's. It looks the palette's observer up by the element it observes, and the destroy test checks that every observer is disconnected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
dominikhorn93
pushed a commit
that referenced
this pull request
Oct 19, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>modeler-shell: 0.2.1</summary> ## [0.2.1](modeler-shell-v0.2.0...modeler-shell-v0.2.1) (2026-10-19) ### Bug Fixes * **shell:** place a tooltip again when it grows after it is shown ([#17](#17)) ([f0149e4](f0149e4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: miragon-release-please[bot] <292359359+miragon-release-please[bot]@users.noreply.github.com>
12 of 26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Context Maps' rollout PR (Miragon/context-maps-modeler#64) failed the shell kit's geometry case in CI: the "Zoom in" tooltip sat 2px past the 12px edge. The tooltip was placed before the web font finished loading and grew by 2px afterwards; locally the font was already cached, so it never showed.
What
ResizeObserverand places itself again while it is shown. The observer is disconnected ondestroy().Part of #4. Ships as
@miragon/modeler-shell0.2.1.🤖 Generated with Claude Code