Skip to content

signing setup: say in the help and README that a failed upload writes no profile #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Interlap01 merged 1 commit into from
Oct 7, 2026
Merged

signing setup: say in the help and README that a failed upload writes no profile #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,9 @@ create certificates. It then:

The upload goes to the repository in `builder.json`, always. When it fails (no
GitHub login, or a token that cannot write secrets) the error is printed and
the command carries on: files, values and the build profile are written and
shown anyway, and it exits non-zero at the end so a script notices. `--json`
the command carries on: files and values are written and shown anyway, but
the build profile is not, since `builder.json` must not claim a set the
repository does not have. It exits non-zero at the end so a script notices. `--json`
reports the same in `github_upload` (`ok` or the error).

**Extensions.** Every extension target (a widget, a share or notification
Expand Down
5 changes: 3 additions & 2 deletions cmd/builder/signing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ way when it is missing.

The names and the values to put in them are always printed too, for
Codemagic, Bitrise or a repository this login cannot write to. A failed upload
is reported and the command carries on — the files and the build profile are
written regardless — and it exits non-zero at the end.`,
is reported and the command carries on — the files are written and the values
printed, but the build profile is not, since builder.json must not claim a set
the repository does not have — and it exits non-zero at the end.`,
RunE: runSigningSetup,
}

Expand Down
Loading