Repository navigation
Declare temporal_valueset generic over every overload of its wrapper - #191
Merged
estebanzimanyi merged 1 commit intoOct 12, 2026
Conversation
temporal_valueset returns the base values of a temporal value as a set, for every temporal type whose values have a set type, and refuses a temporal Boolean through the T_TBOOL literal in its body, which #scoped_signatures would read as the one type it serves. Its scope is declared "*" in meta/type-scope.json, as the scope of the other functions generic over Temporal * is, so it keeps the 19 signatures of getValues and valueSet returning a set that Temporal_valueset declares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temporal_valueset returns the base values of a temporal value as a set, for every temporal
type whose values have a set type, and refuses a temporal Boolean through the T_TBOOL
literal in its body, which #scoped_signatures would read as the one type it serves. Its
scope is declared "*" in meta/type-scope.json, as the scope of the other functions generic
over Temporal * is, so it keeps the 19 signatures of getValues and valueSet returning a set
that Temporal_valueset declares.