Repository navigation
Keep MeosSetSetJoin in the benchmark module alone - #69
Merged
estebanzimanyi merged 1 commit intoOct 2, 2026
Merged
Conversation
MeosSetSetJoin, the hand-written NxN set-set join over two arrays of temporal geometries, lives in the benchmark module, which calls it (BerlinMODSetSetJoinTest) and depends on no other module of the build. The binding module, a pure projection of the MEOS surface with no application or benchmark code as its pom states, carries no copy of it. GENERATION.md names the module the class lives in. Measured. Against MobilityDB 85ad3e2891, the catalog of MEOS-API 1c50d3611a and the generator and jar of JMEOS main 52432a1d, mvn clean test under Maven 3.9.16 builds both modules with no warning line and the 18 and 12 tests pass, the three BerlinMODSetSetJoinTest cases among them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeosSetSetJoin, the hand-written NxN set-set join over two arrays of temporal geometries, lives
in the benchmark module, which calls it (BerlinMODSetSetJoinTest) and depends on no other module
of the build. The binding module, a pure projection of the MEOS surface with no application or
benchmark code as its pom states, carries no copy of it. GENERATION.md names the module the
class lives in.
Measured. Against MobilityDB 85ad3e2891, the catalog of MEOS-API 1c50d3611a and the generator
and jar of JMEOS main 52432a1d, mvn clean test under Maven 3.9.16 builds both modules with no
warning line and the 18 and 12 tests pass, the three BerlinMODSetSetJoinTest cases among them.