Repository navigation
Check the interpolation an omitted argument takes on the typed surface - #74
Merged
estebanzimanyi merged 1 commit intoOct 9, 2026
Merged
Conversation
GeneratedSqlSurfaceTest.anOmittedInterpolationIsTheOneOfTheType checks that appendInstant and tintSeqSetGaps, called without an interpolation, take the one the temporal type supports: appending 5 to a tfloat from 1 to 2 keeps 3 instants and appending 3 keeps 2, the middle one on the line of its neighbours, while appending 3 to a tint keeps 3; interp answers Linear and Step; and tintSeqSetGaps splits three instants with a gap of three days into 2 sequences. Witness: over the catalog of MEOS-API f8f63bd the surface registers no appendInstant over two temporal values, as MobilitySpark MobilityDB#72 measures on the twin test, which fails there on "function appendInstant(tfloat, tfloat) does not exist". Measured over MobilityDB a0480a7d38 and the catalog of MEOS-API catalog/interp-from-signature-type, which #184 merges, with the generator of JMEOS 88694368: the binding module passes its 22 tests and the benchmark module its 12, and the build prints no warning. Why: appendInstant and the sequence set constructors answer on Flink as they do in PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.anOmittedInterpolationIsTheOneOfTheType checks that appendInstant and
tintSeqSetGaps, called without an interpolation, take the one the temporal type supports:
appending 5 to a tfloat from 1 to 2 keeps 3 instants and appending 3 keeps 2, the middle one on
the line of its neighbours, while appending 3 to a tint keeps 3; interp answers Linear and Step;
and tintSeqSetGaps splits three instants with a gap of three days into 2 sequences.
Witness: over the catalog of MEOS-API f8f63bd the surface registers no appendInstant over two
temporal values, as MobilitySpark #72 measures on the twin test, which fails there on "function
appendInstant(tfloat, tfloat) does not exist".
Measured over MobilityDB a0480a7d38 and the catalog of MEOS-API
catalog/interp-from-signature-type, which #184 merges, with the generator of JMEOS 88694368: the
binding module passes its 22 tests and the benchmark module its 12, and the build prints no
warning.
Why: appendInstant and the sequence set constructors answer on Flink as they do in PostgreSQL.