Repository navigation
Check the call that leaves an argument to its NULL default on the typed surface - #75
Merged
estebanzimanyi merged 1 commit intoOct 10, 2026
Conversation
…ed surface GeneratedSqlSurfaceTest.anArgumentLeftToItsNullDefaultIsWhatTheWrapperPasses checks that tintSeqSetGaps over three instants with a gap of three days answers 2 sequences with a one-day maxt and no maxdist, the wrapper passing -1.0, and 1 with neither, the wrapper passing a NULL maxt; and that tfloatSeq of an instant without an interpolation answers a sequence, the wrapper passing INTERP_NONE. Witness: with the generator of JMEOS main the surface registers no call of tintSeqSetGaps without its NULL-default arguments, as MobilitySpark measures on the twin test, which fails there on "function tintSeqSetGaps(array<tint>, interval day) does not exist". Measured over MobilityDB 647acbe4ed, the catalog of MEOS-API catalog/null-default-binds and the generator of JMEOS codegen/null-default-arities: the binding module passes its 23 tests and the benchmark module its 12, and the build prints no warning. Why: a call leaving an argument to its default answers on Flink as it does in PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.anArgumentLeftToItsNullDefaultIsWhatTheWrapperPasses checks that
tintSeqSetGaps over three instants with a gap of three days answers 2 sequences with a one-day
maxt and no maxdist, the wrapper passing -1.0, and 1 with neither, the wrapper passing a NULL
maxt; and that tfloatSeq of an instant without an interpolation answers a sequence, the wrapper
passing INTERP_NONE.
Witness: with the generator of JMEOS main the surface registers no call of tintSeqSetGaps
without its NULL-default arguments, as MobilitySpark measures on the twin test, which fails
there on "function tintSeqSetGaps(array, interval day) does not exist".
Measured over MobilityDB 647acbe4ed, the catalog of MEOS-API catalog/null-default-binds and the
generator of JMEOS codegen/null-default-arities: the binding module passes its 23 tests and the
benchmark module its 12, and the build prints no warning.
Why: a call leaving an argument to its default answers on Flink as it does in PostgreSQL.