Repository navigation
Check the aggregates of every state the catalog states on the typed surface - #76
Merged
estebanzimanyi merged 1 commit intoOct 10, 2026
Conversation
…urface GeneratedSqlSurfaceTest.aggregatesAnswerWhatMobilityDBAnswers checks that tCount, tAvg and tCentroid, whose skip lists carry counts, sums and coordinates, setUnionAgg and spanUnionAgg, whose states are a set and a span set, and extent over boxes, whose state is a box, answer what MobilityDB answers, in a streaming job folding each value into the bytes of the state and in a batch job of two phases; and that tAvg joins two partial states, one read back from the bytes the accumulator's serializer writes for an exchange. GENERATION.md states how the surface carries an aggregate. Witness: with the generator of JMEOS main the test does not compile, the surface holding no class TAvg, and the twin test of MobilitySpark fails on "Cannot resolve routine `tAvg`". Measured over MobilityDB bdc4e41234, the catalog of MEOS-API d259ddbfea and the generator of JMEOS codegen/catalog-aggregates: the binding module passes its 24 tests and the benchmark module its 12, and the build prints no warning. Why: an aggregate answers on Flink as it does in PostgreSQL, whatever state it keeps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.aggregatesAnswerWhatMobilityDBAnswers checks that tCount, tAvg and
tCentroid, whose skip lists carry counts, sums and coordinates, setUnionAgg and spanUnionAgg,
whose states are a set and a span set, and extent over boxes, whose state is a box, answer what
MobilityDB answers, in a streaming job folding each value into the bytes of the state and in a
batch job of two phases; and that tAvg joins two partial states, one read back from the bytes
the accumulator's serializer writes for an exchange. GENERATION.md states how the surface
carries an aggregate.
Witness: with the generator of JMEOS main the test does not compile, the surface holding no
class TAvg, and the twin test of MobilitySpark fails on "Cannot resolve routine
tAvg".Measured over MobilityDB bdc4e41234, the catalog of MEOS-API d259ddbfea and the generator of
JMEOS codegen/catalog-aggregates: the binding module passes its 24 tests and the benchmark
module its 12, and the build prints no warning.
Why: an aggregate answers on Flink as it does in PostgreSQL, whatever state it keeps.