Repository navigation
Test the temporal aggregates of the typed Spark SQL surface - #67
Merged
estebanzimanyi merged 1 commit intoOct 4, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
GeneratedSqlSurfaceTest answers the seven temporal aggregates of the typed surface, mergeAgg, tAndAgg, tCount, tMaxAgg, tMinAgg, tOrAgg and tSum, over the values of GeneratedSurfaceTest, each in a partition of its own so that the combine joins the partial states the shuffle carries, and asserts the texts MobilityDB answers for them, with every instant stated in UTC. It asserts that tCount over a tint answers a tint whose maxValue is an int, and that maxValue(tCount(g)) over the per-trip mergeAgg of three pieces of two trajectories counts the trips, not the pieces: 2 for both, 1 for one. Witness: with the codegen_jvm.py of JMEOS main the typed surface registers no aggregate, and both tests fail to resolve tCount. Measured: generated with the codegen_jvm.py of JMEOS #140 against MobilityDB d9b9c11985, the suite passes, 33 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest answers the seven temporal aggregates of the typed
surface, mergeAgg, tAndAgg, tCount, tMaxAgg, tMinAgg, tOrAgg and tSum, over the
values of GeneratedSurfaceTest, each in a partition of its own so that the
combine joins the partial states the shuffle carries, and asserts the texts
MobilityDB answers for them, with every instant stated in UTC. It asserts
that tCount over a tint answers a tint whose maxValue is an int, and that
maxValue(tCount(g)) over the per-trip mergeAgg of three pieces of two
trajectories counts the trips, not the pieces: 2 for both, 1 for one.
Witness: with the codegen_jvm.py of JMEOS main the typed surface registers no
aggregate, and both tests fail to resolve tCount.
Measured: generated with the codegen_jvm.py of JMEOS #140 against MobilityDB
d9b9c11985, the suite passes, 33 tests.