Repository navigation
Check the constructors from an array of fixed-size values on the typed surface - #71
Merged
estebanzimanyi merged 1 commit intoOct 9, 2026
Conversation
…d surface
GeneratedSqlSurfaceTest.arraysCrossAsSparkArrays checks that spanset over an array of two int
spans answers {[1, 3), [5, 7)}, and that set over three network points, one repeated, and over
two circular buffers answers 2 values each: the elements reach MEOS as the contiguous C array
spanset_make, npointset_make and cbufferset_make read.
Witness: with the generator of JMEOS main the surface registers no spanset over an array of
spans, and the test fails on "function spanset(array<intspan>) does not exist".
Measured over MobilityDB 2a1d52a7ee, the catalog of MEOS-API catalog/struct-value-input-arrays
and the generator of JMEOS codegen/struct-value-arrays: the 35 tests pass.
Why: a constructor from an array of values answers on Spark as it does in PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.arraysCrossAsSparkArrays checks that spanset over an array of two int
spans answers {[1, 3), [5, 7)}, and that set over three network points, one repeated, and over
two circular buffers answers 2 values each: the elements reach MEOS as the contiguous C array
spanset_make, npointset_make and cbufferset_make read.
Witness: with the generator of JMEOS main the surface registers no spanset over an array of
spans, and the test fails on "function spanset(array) does not exist".
Measured over MobilityDB 2a1d52a7ee, the catalog of MEOS-API catalog/struct-value-input-arrays
and the generator of JMEOS codegen/struct-value-arrays: the 35 tests pass.
Why: a constructor from an array of values answers on Spark as it does in PostgreSQL.