Repository navigation
Check the aggregates of every state the catalog states on both Spark surfaces - #74
Merged
estebanzimanyi merged 1 commit intoOct 10, 2026
Conversation
…surfaces GeneratedSqlSurfaceTest.aggregatesOfEveryStateAnswerWhatMobilityDBAnswers checks that tAvg and tCentroid, whose skip lists carry sums, counts and coordinates, setUnionAgg and spanUnionAgg, whose states are a set and a span set, and extent over boxes and over a temporal float, whose state is a box, answer what MobilityDB answers over values in partitions of their own, so every partial state crosses the shuffle as the bytes its serialize function or its type's codec writes. GeneratedSurfaceTest.temporal_aggregates_answer_what_mobilitydb_answers checks tAvg over binary values on the UDF surface. Witness: with the generator of JMEOS main both tests fail on "Cannot resolve routine `tAvg`". Measured over MobilityDB bdc4e41234, the catalog of MEOS-API d259ddbfea and the generator of JMEOS codegen/catalog-aggregates: the 38 tests pass. Why: an aggregate answers on Spark as it does in PostgreSQL, whatever state it keeps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.aggregatesOfEveryStateAnswerWhatMobilityDBAnswers checks that tAvg and
tCentroid, whose skip lists carry sums, counts and coordinates, setUnionAgg and spanUnionAgg,
whose states are a set and a span set, and extent over boxes and over a temporal float, whose
state is a box, answer what MobilityDB answers over values in partitions of their own, so every
partial state crosses the shuffle as the bytes its serialize function or its type's codec
writes. GeneratedSurfaceTest.temporal_aggregates_answer_what_mobilitydb_answers checks tAvg over
binary values on the UDF surface.
Witness: with the generator of JMEOS main both tests fail on "Cannot resolve routine
tAvg".Measured over MobilityDB bdc4e41234, the catalog of MEOS-API d259ddbfea and the generator of
JMEOS codegen/catalog-aggregates: the 38 tests pass.
Why: an aggregate answers on Spark as it does in PostgreSQL, whatever state it keeps.