fix: address 19 review findings across workers, claims, UI, and board reads - #264
Draft
seanperkins wants to merge 8 commits into
Draft
seanperkins wants to merge 8 commits into
seanperkins wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review found paths that could bypass delivery protection, close valid PRs on Git errors, trust fork branch names, release replacement claims, or apply UI actions to the wrong issue. It also found restart recovery gaps and unbounded board reads.
This PR combines the fixes produced by six subagents, with targeted regressions and cross-review.
Validation
f767cf9ec9c8b5f269fd7aa4c1237129d0912930.On the synthetic 10,000-issue / 199,960-event fixture, task selection fell from about 3.56 seconds to 5.45–5.94 ms. An empty-project issue list fell from 95–98 ms to 1.04–1.34 ms. Default board payload was 715 bytes and the first all-history page was 10,270 bytes, compared with the previous roughly 25 MB response. These are local benchmark measurements. Legacy full
/issuesand MCP search responses remain compatible.Migration and rollout
0020_review_performanceadds mechanical indexes through the existing migration mechanism. PR feat: a human-only gate that actually requires a human act (SYD-281) #243 also adds migration 0020: whichever PR merges second must reconcile/regenerate the SQL, journal, and snapshot together before deployment. This PR stands alone on current main.Issue closure
Closes #245
Closes #246
Closes #247
Closes #248
Closes #249
Closes #250
Closes #251
Closes #252
Closes #253
Closes #254
Closes #255
Closes #256
Closes #257
Closes #258
Closes #259
Closes #260
Closes #261
Closes #262
Closes #263