Switch to sys.base_prefix for better Lib path detection - #160
Open
Linus-XZX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the approach to finding the
Libdirectory, from under parent dir ofsys.executableto undersys.base_prefix.The current approach fails when the Python interpreter invoked is from a virtual environment, since in that case the executable becomes
\path\to\venv\Scripts\python.exewhere the prefixLibis\path\to\venv\Lib.Changing
src/proxy/build_pythoncore.pyline 7 to use.parent.parentwill make the assert go through, but then result in an emptypythoncore.zip, since the real libraries to include in the archive are under the base prefix rather than the venv'sLib.This change should not hurt either if the interpreter is not in a venv, since in that case
sys.base_prefixis just the same as the parent ofsys.executable.Tested with the base environment and venv, on both
pymanaged anduvmanaged Python installations.